Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results of other version of libraries #64

Open
windows7897 opened this issue Mar 24, 2023 · 2 comments
Open

Results of other version of libraries #64

windows7897 opened this issue Mar 24, 2023 · 2 comments

Comments

@windows7897
Copy link

windows7897 commented Mar 24, 2023

Hi,
Thank you for the open source code.

I reproduce your model with the same libraries with other version

torch 1.13.0
torch-cluster 1.6.0+pt113cu116
torch-geometric 2.2.0
torch-scatter 2.1.0+pt113cu116
torch-sparse 0.6.16+pt113cu116
torch-spline-conv 1.2.1+pt113cu116
torchmetrics 0.11.4
torchvision 0.14.0

from my case, i get flowing results
F1 Recall Precision
SWAT 0.778047 0.643728 0.982768
WADI 0.461867 0.349515 0.682105

There is huge deviation at WADI dataset

I can't doubt any cause except library version

I want to make up the environment with your same case
pytorch-geometric can't be installed on pytorch version 1.5.1 now

so would you check your model performance at recent version of libraries?

@d-ailin
Copy link
Owner

d-ailin commented Apr 5, 2023

Sorry for the late reply. It might be a bit troublesome to adapt the codes with recent version of libraries as there seems changes in some API or implementations in the updated libraries. As for the performance, could you check if the data is processed like https://github.com/d-ailin/GDN/tree/main/scripts? It could also probably affect the result. Thanks.

@windows7897
Copy link
Author

Thank you for your reply

My data have been preprocessed by your code

Could you share your environment by Docker images?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants