Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed odysee embeds bug #730 #773

Merged
merged 13 commits into from
Jun 7, 2021
Merged

Fixed odysee embeds bug #730 #773

merged 13 commits into from
Jun 7, 2021

Conversation

aaashir
Copy link
Member

@aaashir aaashir commented Jun 2, 2021

I've fixed the embeds bug for https://odysee.com.

@hivephilippines @stinkymonkeyph

@aaashir aaashir linked an issue Jun 2, 2021 that may be closed by this pull request
Make it so links to https://odysee.com work. #730
Open
@aaashir aaashir requested a review from stinkymonkeyph June 2, 2021 23:58
@hivephilippines
Copy link

Good job @aaashir

@hivephilippines
Copy link

Is this the bug you fixed with this PR? @aaashir

https://d.buzz/#/@crebspark/c/pvdpp4t8tf73vxyc63eiml

@aaashir
Copy link
Member Author

aaashir commented Jun 4, 2021

Is this the bug you fixed with this PR? @aaashir

https://d.buzz/#/@crebspark/c/pvdpp4t8tf73vxyc63eiml

@hivephilippines - Yes, it is the one I fixed.

stinkymonkeyph
stinkymonkeyph requested changes Jun 5, 2021
View reviewed changes
Copy link
Member

@stinkymonkeyph stinkymonkeyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the fix is not working

http://localhost:3000/#/@crebspark/c/pvdpp4t8tf73vxyc63eiml

image

@aaashir
Copy link
Member Author

aaashir commented Jun 5, 2021

fix is not w

Okay @stinkymonkeyph , I'll check it.

@aaashir
Copy link
Member Author

aaashir commented Jun 5, 2021 •
edited
Loading

@stinkymonkeyph - All videos from Odysee are embedding. That link is not embedding because it contains ' and it's not even loading when I manually visit the embed link.

See: https://odysee.com/$/embed/Dead-And-Paralyzed-After-The-Covid-19-'Vaccine'

It shows error.

image

@stinkymonkeyph
Copy link
Member

Maybe you can encode the url just like https://odysee.com/@BNN:6/Dead-And-Paralyzed-After-The-Covid-19-%27Vaccine%27:b

@aaashir
Copy link
Member Author

aaashir commented Jun 7, 2021

Maybe you can encode the url just like https://odysee.com/@BNN:6/Dead-And-Paralyzed-After-The-Covid-19-%27Vaccine%27:b

Still, it shows the same error with https://odysee.com/$/embed/Dead-And-Paralyzed-After-The-Covid-19-%27Vaccine%27 link

@stinkymonkeyph
Copy link
Member

Okay, let's assume that link is the problem and this PR is correct 🎉

@stinkymonkeyph stinkymonkeyph merged commit ad9301b into dev Jun 7, 2021
@stinkymonkeyph stinkymonkeyph deleted the fix-odysee-embeds branch June 7, 2021 12:52
stinkymonkeyph added a commit that referenced this pull request Jun 16, 2021
@stinkymonkeyph @aaashir
release 3.16.0 (#808)
d77a062 
* Add support for dollar vigilante video embeds #774 (#778)

* Fix banned video embeds url format #769 (#779)

* Add character counter to comments (#780)

* Add support for dapplr video embeds #147 (#784)

* add more menu (#793)

* add freeworldnews video embeds #789 (#790)

* Fixed odysee embeds bug #730 (#773)

* exclude first three links from buzz counter (#795)

* update cache clearing method (#797)

* update env

* automatically extract hashtags from content (#799)

* remove title for buzzes with only link post (#800)

* Fix UI break problem due to Twitter Embeds (#798)

* fixed ui breaking #748

* Fixed the breaking error

* add '@' sign in username field (#803)

* fixed odysee embeds bug

* revert more menu (#806)

* update package.json

* fixed blank page bug on ios (#807)

Co-authored-by: Aashir Shaikh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinkymonkeyph stinkymonkeyph stinkymonkeyph requested changes

Assignees
No one assigned
Labels
need testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it so links to https://odysee.com work.
5 participants
@aaashir @hivephilippines @stinkymonkeyph @PostNZT @rmcuenen