Skip to content

Commit ea3dc8d

Browse files
committed
Run clippy using the stable toolchain
So far we were running clippy on our minimum supported Rust version in CI. Doing so is fine conceptually, but it means one more version to update. What's more, we also don't get the latest and greatest suggestions that clippy provides. With this change we switch to running clippy on the most recent stable toolchain, which fixes these problems.
1 parent 6b0ea6f commit ea3dc8d

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

.github/workflows/ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ jobs:
4848
- uses: actions/checkout@v2
4949
- uses: actions-rs/toolchain@v1
5050
with:
51-
toolchain: 1.57.0
51+
toolchain: stable
5252
components: clippy
5353
override: true
5454
- run: cargo clippy --no-deps --all-targets --all-features -- -A unknown_lints -D warnings

src/lib.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright (C) 2019-2021 Daniel Mueller <[email protected]>
1+
// Copyright (C) 2019-2022 Daniel Mueller <[email protected]>
22
// SPDX-License-Identifier: GPL-3.0-or-later
33

44
#![warn(
@@ -43,6 +43,7 @@
4343
where_clauses_object_safety,
4444
while_true
4545
)]
46+
#![allow(clippy::let_unit_value)]
4647

4748
//! A crate for converting data on a WebSocket channel into a stream of
4849
//! JSON decoded objects.

src/wrap.rs

+1
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,7 @@ impl Pinger {
216216
}
217217

218218
/// Attempt to advance the ping state by one step.
219+
#[allow(clippy::result_large_err)]
219220
fn advance<S>(&mut self, sink: &mut S, ctx: &mut Context<'_>) -> Result<(), S::Error>
220221
where
221222
S: Sink<WebSocketMessage, Error = WebSocketError> + Unpin,

0 commit comments

Comments
 (0)