Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Text Editor #861

Closed
nevumx opened this issue May 27, 2024 · 3 comments
Closed

[FEATURE REQUEST] Text Editor #861

nevumx opened this issue May 27, 2024 · 3 comments

Comments

@nevumx
Copy link

nevumx commented May 27, 2024

Similar to how the hex editor can change individual bytes, it would be nice if the Text Viewer had an "edit" mode where new characters could be inserted with the existing software keyboard that is used to name/rename files. (Perhaps an "enter" key might need to be added) I assume that the limitation here is that while it is easy to change bytes, adding them to a larger text file might be problematic from a memory allocation standpoint, so perhaps a limit of 10 MB or so could be imposed, depending on the memory model used by GM9.

@Wolfvak
Copy link
Collaborator

Wolfvak commented Jun 15, 2024

Already discussed and rejected, please see #117 and #805

@Wolfvak Wolfvak closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2024
@nevumx
Copy link
Author

nevumx commented Jun 23, 2024

Okay, I see those threads now, that being said, I decided to just go forward and implement it myself. The text viewer code is indeed a PITA, but I have already implemented UTF-8 support and a cursor with U/D/L/R movement. I am going to work on moving the window with the cursor, and integrating the keyboard with text insertion/deletion next, but ideally I should be able to make this happen without mutilating the text viewer code too much. I'll keep you all posted...

@nevumx
Copy link
Author

nevumx commented Jun 28, 2024

PR Ready for consideration: #868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants