Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App is a bit slow. Can it be optimised? #102

Open
TheRealMystic opened this issue Jul 27, 2022 · 10 comments
Open

App is a bit slow. Can it be optimised? #102

TheRealMystic opened this issue Jul 27, 2022 · 10 comments
Labels
enhancement New feature or request help/discussion wanted Extra attention is needed Needs Info/Repro Needs more details or reproduction instructions.
Milestone

Comments

@TheRealMystic
Copy link
Collaborator

Both my phones are quite powerful, with one running on Snapdragon 8 Gen 1 and the other running on Snapdragon 865. Yet, the app takes a few seconds (usually between 3 to 5 seconds) to load all the info when launching it, when using filters, sorting, refreshing, etc.

Can it be optimised to make it Superfast, i.e. less than 1 second?

@TheRealMystic TheRealMystic added the Needs Info/Repro Needs more details or reproduction instructions. label Jul 27, 2022
@d4rken
Copy link
Member

d4rken commented Jul 27, 2022

I'll check, reading the whole app list multiple ways is costly. Especially reading it with different flags to find those extra apps in work profiles is also costing us time.

@d4rken
Copy link
Member

d4rken commented Jul 27, 2022

Super fast on first launch will require on-disk caching.
Possible to first use the cached data if not too old, while in the background loading new data.
Quite some work, something for the future?

Depending on how fast the storage is, it may not be faster on every device 🤔.

@d4rken d4rken added enhancement New feature or request help/discussion wanted Extra attention is needed labels Jul 27, 2022
@TheRealMystic
Copy link
Collaborator Author

TheRealMystic commented Jul 27, 2022

Super fast on first launch will require on-disk caching. Possible to first use the cached data if not too old, while in the background loading new data. Quite some work, something for the future?

Depending on how fast the storage is, it may not be faster on every device 🤔.

Most devices are now UFS 3.0 and above. They are quite fast. Even those with UFS 2.x should be fast enough for this purpose.

@d4rken d4rken added this to the Next Tasks milestone Jul 27, 2022
@d4rken
Copy link
Member

d4rken commented Jul 27, 2022

UFS3.0 are just labels, real world looks different.
Also if users do something like add extra sdcard and adopt as internal storage, it could be super slow.

@d4rken d4rken modified the milestones: Next Tasks, Blue Sky Jul 27, 2022
@dragonGod97677
Copy link
Contributor

dragonGod97677 commented Jul 28, 2022

UFS3.0 are just labels, real world looks different. Also if users do something like add extra sdcard and adopt as internal storage, it could be super slow.

Yup, those are just labels.
I did adopt my sd card as internal storage and kinda slow

@dragonGod97677
Copy link
Contributor

And also, reducing the life of nand flash/sd cards

@TheRealMystic
Copy link
Collaborator Author

Internet Security companies found a new way to improve the speeds of their antivirus scans. They implemented things in a way that can track all changes since the last scan, and the next scan would only scan those changes. This made the antivirus scans real fast and also placed lesser load on resources.

Can something along those line be implemented in PP? This will make all operations real fast.

@dragonGod97677
Copy link
Contributor

dragonGod97677 commented Jul 31, 2022

Internet Security companies found a new way to improve the speeds of their antivirus scans. They implemented things in a way that can track all changes since the last scan, and the next scan would only scan those changes. This made the antivirus scans real fast and also placed lesser load on resources.

Can something along those line be implemented in PP? This will make all operations real fast.

PC is more faster than android, even a budget pc will be still faster than android.

Also this:

Super fast on first launch will require on-disk caching.
Possible to first use the cached data if not too old, while in the background loading new data.
Quite some work, something for the future?

Depending on how fast the storage is, it may not be faster on every device 🤔.

Not every person on earth uses new phone/old phone with fast storage

@TheRealMystic
Copy link
Collaborator Author

PC is more faster than android, even a budget pc will be still faster than android.

Phones are quite fast these days.

Not every person on earth uses new phone/old phone with fast storage

Even budget phones today have good speeds for normal functions. There is a target API and minimum API for apps. So a compromise has to be made in terms of supporting very old devices.

@vertigo220
Copy link

For this app to monitor all changes, it would have to be constantly running, which would use some processing power, albeit not much, as well as battery, which may be a bigger issue. Neither of these are issues with AV on PCs. A better method may be using snapshots, to quickly see what changes were made since last time, effectively doing the same thing as constant monitoring, but that would likely take some time and result in little if any noticeable improvement. I'd think it would be easier to speed up filtering, etc, which is also something you're likely to do a lot more, than startup, which probably isn't something you're going to be doing that often, certainly not so much that a few seconds is a big deal. Really, though, I'm impressed with how fast it is for how much data it has to look through. Startup only takes probably 3-4 seconds and filtering is either instant or takes maybe a couple seconds, and I have a lower-end processor than you. So maybe there's something else going on. Maybe you have a lot more apps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help/discussion wanted Extra attention is needed Needs Info/Repro Needs more details or reproduction instructions.
Projects
None yet
Development

No branches or pull requests

4 participants