Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sideloaded Apps Filter #110

Closed
TheRealMystic opened this issue Jul 28, 2022 · 3 comments
Closed

Sideloaded Apps Filter #110

TheRealMystic opened this issue Jul 28, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@TheRealMystic
Copy link
Collaborator

TheRealMystic commented Jul 28, 2022

Apps whose install source is not identifiable are being included with Sideloaded Apps.

I think if an app has been Sideloaded, PP can definitely identify the source. So please exclude apps which have install source as 'Information Not Available' from this filter.

In this context, I hope PP can identify apps Sideloaded via ADB. Such apps must be included with Sideloaded Apps filter.

@TheRealMystic TheRealMystic added the bug Something isn't working label Jul 28, 2022
@TheRealMystic
Copy link
Collaborator Author

Based on what you said here:

#111 (comment)

Is it a safer to leave this filter as it is at the moment?

@d4rken
Copy link
Member

d4rken commented Jul 28, 2022

I think the current sideloaded = !isSystemApp && installer == null is a good compromise, it's useful and not really wrong either.

@TheRealMystic
Copy link
Collaborator Author

So can we close this ticket? Or would you like to take a look at it later?

@d4rken d4rken closed this as completed Jul 28, 2022
@d4rken d4rken closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants