Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you mind if I write a request to be added to F-Droid? #148

Open
Artem13327 opened this issue Sep 27, 2022 · 9 comments
Open

Do you mind if I write a request to be added to F-Droid? #148

Artem13327 opened this issue Sep 27, 2022 · 9 comments
Labels
question Further information is requested

Comments

@Artem13327
Copy link

No description provided.

@d4rken
Copy link
Member

d4rken commented Sep 27, 2022

I don't mind, see also https://apt.izzysoft.de/packages/eu.darken.myperm/

@d4rken d4rken added the question Further information is requested label Sep 27, 2022
@d4rken
Copy link
Member

d4rken commented Sep 27, 2022

AuthorName: Matthias Urhahn
AuthorEmail: [email protected]
AuthorWebSite: https://darken.eu
Donate: https://github.com/sponsors/d4rken

SourceCode: https://github.com/d4rken-org/permission-pilot
IssueTracker: https://github.com/d4rken-org/permission-pilot/issues
Changelog: https://github.com/d4rken-org/permission-pilot/releases

@offa
Copy link

offa commented Dec 4, 2022

Are there any news regarding F-Droid submission?

@d4rken
Copy link
Member

d4rken commented Dec 4, 2022

Hm, basically waiting for CAPod to be approved, which is waiting on someone from F-Droid for review:
https://gitlab.com/fdroid/rfp/-/issues/2222#note_1116255404

CAPod uses the same new build script that generates a VERSION file that F-Droid can parse for automatic builds:
https://github.com/d4rken-org/permission-pilot/blob/main/VERSION

Once that is working, the same script could be used for all my apps to get automatic builds on f-droid.

@IzzySoft
Copy link
Contributor

@d4rken for myperms, we have an issue concerning updates. Our update checker only parses the build.gradle using regular expressions, so variables or function calls do not work. Which means we need versionCode and versionName available literally (which they are currently not) – ideally in the place just pointed to, but if you prefer you could also have that defined when making a release by writing it e.g. to a version.txt, for example using the same syntax as Flutter does (version: <versionName>+<versionCode>). Could that be done?

@d4rken
Copy link
Member

d4rken commented Apr 27, 2023

Permission Pilot uses the same release script as CAPod, and creates a VERSION file:
https://github.com/d4rken-org/permission-pilot/blob/main/VERSION

Could the same solution from CAPod be used here too?

@IzzySoft
Copy link
Contributor

Yes, sure! That's what I meant by "as Flutter does". A + or a space as separator – as long as you don't have spaces in your versionName that should not matter at all πŸ˜„ Just let us know once it's there, and where to look for it (ideally in the RFP), and we'll pick it up.

@d4rken
Copy link
Member

d4rken commented Apr 29, 2023

@IzzySoft Permission Pilot already uses the same scheme as CAPod, the VERSION file is available.
https://github.com/d4rken-org/permission-pilot/blob/main/VERSION

What is the blocker here? Did I forget some tweak that I did in CAPod and didn't do here? πŸ€”

@IzzySoft
Copy link
Contributor

Ah, right – must have missed that. Thanks Matthias, adjusted in the RFP and marked it "ready for packaging" then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants