Skip to content
This repository was archived by the owner on Aug 18, 2021. It is now read-only.

!stop emp handling #12

Open
ImTheDeveloper opened this issue Oct 19, 2020 · 3 comments
Open

!stop emp handling #12

ImTheDeveloper opened this issue Oct 19, 2020 · 3 comments

Comments

@ImTheDeveloper
Copy link

The current stop command does not take into account emp init

Stopping 1900 Vindicator (11.4k) as t1 requires Gryphon: 1131 (12.4k) Centaur: 699 (15k) Spider: 2639 (11.9k) Scarab: 660 (12.6k) Revenant: 1320 (11.8k) Ghost: 679 (12.1k) Cutlass: 1080 (11.3k) Vindicator: 1584 (9504) Ranger: 660 (13.1k)

In the example spider needs to be around ~5.6k due to being emp'd first by vindicator.

Unsure if its relevant for !eff since we do not account for ships dieing first there

@d7415
Copy link
Owner

d7415 commented Oct 19, 2020

Unsure if its relevant for !eff since we do not account for ships dieing first there

I don't think we currently consider that in !stop either. I have a patch (not mine) that I was going to incorporate at some point and then apparently didn't. I'll look at adding it now.

Aside: It's getting towards time to look at switching to other, better maintained tools or someone forking this. munin has been getting much more attention recently.

@d7415
Copy link
Owner

d7415 commented Oct 19, 2020

Looks like the patch only handles norm <-> norm and emp <-> emp so will need more work...

@d7415
Copy link
Owner

d7415 commented Oct 19, 2020

I don't have time to fix it right now. If you want to have a go, I've posted it here: e8014c1. !stop doesn't seem to consider emp targets, !eff doesn't consider norm attacking emp or vice versa.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants