.del(key, options, cb) method not returning a Promise #25

markoivanovski · 2021-10-08T03:47:00Z

Line 69 in 3bf4514

self.del = (key, options, cb) => {

The delete method does not appear to be wrapped in a Promise, giving it a different signature to the other methods. Believe it is supposed to?

self.del = (key, options, cb) => {
  if (typeof options === 'function') {
    cb = options;
  }

  redisCache.del(key, handleResponse(cb));
};

markoivanovski · 2021-10-11T09:00:28Z

@dabroek I have linked a PR that fixes the issue, do you think it could be merged and release?

Thanks!

ehaynes99 · 2022-04-01T20:53:36Z

Was the PR just closed due to inactivity? This has been inconsistent with the cache-manager#Cache interface all along, and the fix simply follows the pattern of the others...

Tirke · 2022-08-09T07:28:52Z

@markoivanovski Did a rewrite of this package with del returning a promise here: https://www.npmjs.com/package/@tirke/node-cache-manager-ioredis

markoivanovski mentioned this issue Oct 8, 2021

Ensure .del() method returns a Promise so it aligns with the signature of other methods #26

Closed

regevbr linked a pull request Apr 10, 2022 that will close this issue

add mget support #29

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

.del(key, options, cb) method not returning a Promise #25

.del(key, options, cb) method not returning a Promise #25

markoivanovski commented Oct 8, 2021 •

edited

Loading

markoivanovski commented Oct 11, 2021

ehaynes99 commented Apr 1, 2022

Tirke commented Aug 9, 2022 •

edited

Loading

.del(key, options, cb) method not returning a Promise #25

.del(key, options, cb) method not returning a Promise #25

Comments

markoivanovski commented Oct 8, 2021 • edited Loading

markoivanovski commented Oct 11, 2021

ehaynes99 commented Apr 1, 2022

Tirke commented Aug 9, 2022 • edited Loading

markoivanovski commented Oct 8, 2021 •

edited

Loading

Tirke commented Aug 9, 2022 •

edited

Loading