Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supports ttl constructor option with external redis instances #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Supports ttl constructor option with external redis instances #15

wants to merge 1 commit into from
+32 −2

Conversation

wbk
Copy link

@wbk wbk commented Feb 3, 2021

This addresses the issue in #14

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 93.333% when pulling 85eb75d on wbk:master into 3bf4514 on dabroek:master.

@coveralls
Copy link

coveralls commented Feb 3, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.7%) to 92.5% when pulling 5cbf593 on wbk:master into 3bf4514 on dabroek:master.

@tonivj5 tonivj5 mentioned this pull request Apr 2, 2021
Closed
@dylanseago
Copy link

Can we get this merged? I can confirm this PR fixes the issue

@omerautodesk
Copy link

omerautodesk commented Aug 16, 2022 •
edited
Loading

Is this going to be merged, or can we declare this package as deprecated?
@dabroek @marcoreni

@luluhoc
Copy link

luluhoc commented Dec 13, 2022

@dabroek

@jeanbaptistesouvestre
Copy link

Hello, would it be possible to merge this ? Thanks ! 🙏

@surahj
Copy link

surahj commented Aug 6, 2023

Is it still possible to merge?

@artyomtrubchik
Copy link

guys, could you review this pr and merge 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanre-ibraheem lanre-ibraheem lanre-ibraheem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@wbk @coveralls @dylanseago @omerautodesk @luluhoc @jeanbaptistesouvestre @surahj @artyomtrubchik @lanre-ibraheem