Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Heroku Status command #26

Open
jacobsmith opened this issue Feb 11, 2016 · 2 comments
Open

Add Heroku Status command #26

jacobsmith opened this issue Feb 11, 2016 · 2 comments

Comments

@jacobsmith
Copy link

There is currently a heroku-status hubot script at https://github.com/github/hubot-scripts/blob/master/src/scripts/heroku-status.coffee . However, if my understanding of how the hubot eco-system has changed is correct, additional pull requests into hubot-scripts is no longer the preferred method. I think pulling that same functionality into this script would make sense, especially for verifying if Heroku is functioning correctly. It would not need any of the API auth, as the status endpoint is public.

I would be more than willing to submit a PR for this, but I wanted to see if you felt this project could use that functionality before I forked and added the code!

@daemonsy
Copy link
Owner

I think it's a useful addition, I think we are both probably thinking about using the official API.

Happy to receive a PR for this! :)

@jacobsmith
Copy link
Author

Awesome, thanks! I'm working on a PR for this and have a request out to Heroku for some more documentation on what failure response JSON looks like, just so the tests can be more accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants