Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with LossFunctions.jl, test with least squares #11

Merged
merged 18 commits into from
Oct 9, 2023

Conversation

alexmul1114
Copy link
Contributor

Issue #10

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e31ed21) 100.00% compared to head (3ca2ec5) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #11   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         4    +1     
  Lines           68        70    +2     
=========================================
+ Hits            68        70    +2     
Files Coverage Δ
ext/LossFunctionsExt.jl 100.00% <100.00%> (ø)
src/GCPDecompositions.jl 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dahong67
Copy link
Owner

dahong67 commented Oct 4, 2023

Looking good!

I think we should put this functionality in a package extension: https://pkgdocs.julialang.org/v1/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions)

For backwards compatibility, let's take this approach for now: https://pkgdocs.julialang.org/v1/creating-packages/#Transition-from-normal-dependency-to-extension

Could you try getting that to work?

@dahong67
Copy link
Owner

dahong67 commented Oct 9, 2023

Great job! 🎊

@dahong67 dahong67 merged commit 4f3ef37 into dahong67:master Oct 9, 2023
12 checks passed
@alexmul1114 alexmul1114 deleted the lossfunctions branch October 9, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants