-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility with LossFunctions.jl, test with least squares #11
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 4 +1
Lines 68 70 +2
=========================================
+ Hits 68 70 +2
☔ View full report in Codecov by Sentry. |
Looking good! I think we should put this functionality in a package extension: https://pkgdocs.julialang.org/v1/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions) For backwards compatibility, let's take this approach for now: https://pkgdocs.julialang.org/v1/creating-packages/#Transition-from-normal-dependency-to-extension Could you try getting that to work? |
Great job! 🎊 |
Issue #10