Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize components #64

Closed
3 tasks done
Tracked by #16
dahong67 opened this issue Aug 20, 2024 · 0 comments · Fixed by #65
Closed
3 tasks done
Tracked by #16

Normalize components #64

dahong67 opened this issue Aug 20, 2024 · 0 comments · Fixed by #65
Assignees

Comments

@dahong67
Copy link
Owner

dahong67 commented Aug 20, 2024

Initial implementation done in #58

Remaining features needed:

  • Add kwarg (dims?) to specify what to normalize
  • Add kwarg (distribute_to) to specify where to absorb / distribute the extra scaling
  • Handle zero components (maybe have a trim kwarg?) (ignore zero norms, i.e., treat them as though they were unit norm)
@dahong67 dahong67 changed the title normalization of the components Normalization of the components Aug 20, 2024
@dahong67 dahong67 changed the title Normalization of the components Normalize and sort components Aug 20, 2024
@dahong67 dahong67 self-assigned this Aug 20, 2024
@dahong67 dahong67 changed the title Normalize and sort components Normalize components Aug 20, 2024
@dahong67 dahong67 linked a pull request Aug 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant