Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update local camera #49

Merged
merged 2 commits into from
Oct 2, 2024
Merged

fix: update local camera #49

merged 2 commits into from
Oct 2, 2024

Conversation

jamsea
Copy link
Contributor

@jamsea jamsea commented Oct 1, 2024

Fixes a bug where the local user's video feed was not updating when the video input changed.

Copy link

github-actions bot commented Oct 1, 2024

size-limit report 📦

Path Size
dist/index.cjs.js 3.3 KB (+2.77% 🔺)
dist/index.esm.js 3.26 KB (+2.94% 🔺)
dist/index.umd.js 3.41 KB (+2.77% 🔺)

@jamsea jamsea force-pushed the hush/fixLocalVideoSwitch branch from ff2b2ef to 70999e7 Compare October 1, 2024 08:35
@jamsea jamsea requested review from pojala and Regaddi October 1, 2024 08:35
src/VCSWebRenderer.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@pojala pojala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for this!

Revert rollup

Update tsconfig.json

Fix test

fix: use getVideoTracks

Update mocks from daily-react

Fix test
@jamsea jamsea force-pushed the hush/fixLocalVideoSwitch branch from f2486cf to 396fe7f Compare October 2, 2024 06:41
@jamsea jamsea merged commit a27252b into main Oct 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants