Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getMatches and getHotMatches #2

Open
dajk opened this issue May 16, 2017 · 5 comments
Open

Add getMatches and getHotMatches #2

dajk opened this issue May 16, 2017 · 5 comments
Assignees
@dajk
Labels
feature help wanted

Comments

@dajk
Copy link
Owner

dajk commented May 16, 2017

No description provided.

@dajk dajk added the feature label May 17, 2017
@dajk dajk self-assigned this May 17, 2017
@dajk dajk mentioned this issue Nov 18, 2017
Closed
@honjes
Copy link

honjes commented Oct 8, 2019 •
edited
Loading

What is meant with getHotMatches ?
The live matches ?

@dajk
Copy link
Owner Author

dajk commented Oct 11, 2019

Hi again @honjes , I am sorry I am responding just now.

With getHotMatches I thought this, if that make any sense? What's your thought?

Screen Shot 2019-10-11 at 17 04 03

Are you willing to implement them?

@honjes
Copy link

honjes commented Oct 11, 2019

Yes sure

@honjes
Copy link

honjes commented Oct 11, 2019 •
edited
Loading

What about calling it getLiveMatches and returning Live matches ?
Or it could return only matches with 1 star and more.
I think that is the way that it makes most sens.
What do you think ?

@honjes honjes mentioned this issue Oct 14, 2019
Closed
@dajk
Copy link
Owner Author

dajk commented Oct 15, 2019

For me, the idea of hot matches was just more relevant for most of the users. If I would have a CS website, I'd probably rather show just those than having some random ones. Does that make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dajk dajk

Labels
feature help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dajk @honjes