Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conflict with jQuery #8

Open
kimas-m opened this issue Mar 4, 2015 · 5 comments
Open

conflict with jQuery #8

kimas-m opened this issue Mar 4, 2015 · 5 comments

Comments

@kimas-m
Copy link

kimas-m commented Mar 4, 2015

when I use your code with some simple (fadeI; fadeOut) jQuery i get "undefined is not a function" it points to this line "var collection = ( tweeners[ prop ] || [] ).concat( tweeners[ "*" ] )," on jQuery. It works when i dont use any of game code. How to solve this problem because i want to use jQuery code too
@dinc5150
Copy link

@kimasgold Did you find a way around it, so that you could use jQuery?

dinc5150 added a commit to dinc5150/pacman that referenced this issue Nov 25, 2016
@dinc5150
Update to make compatible with jQuery
2a69993 
This update fixes issues where the file would cause jQuery to break. 
This is in response to daleharvey#8 
For more info on the reason why it causes an issue - http://stackoverflow.com/questions/14941657/why-does-this-javascript-prototype-function-break-jquery
@dinc5150 dinc5150 mentioned this issue Nov 25, 2016
Open
@dinc5150
Copy link

Added pull request to fix this issue #14

@kimas-m
Copy link
Author

kimas-m commented Nov 25, 2016

Yes I think i found a way around it, that it wont interfere with jquery. Just now i cant remember this at all. sorry. back then i was frustrating on this matter. but i can see you found a way to fix it too.

@dinc5150
Copy link

Thanks @kimasgold . Yes, I a "Clone" method added to the Object.prototype and jQuery was having issues with the function being added to all objects. As the method was only ever used once in the code, I simply changed to to be a standalone method and passed the object to it. All my jQuery animations are now working fine with the update.

@johannesE
Copy link

Please merge this. Because of this, I fucked up my production environment on April 1st. 🙄
Should have done proper testing..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johannesE @kimas-m @dinc5150