Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap exceptions in an IntrinioException as per ServiceStack.Stripe style? #1

Open
daleholborow opened this issue Nov 18, 2016 · 0 comments

Comments

@daleholborow
Copy link
Owner

daleholborow commented Nov 18, 2016

https://github.com/ServiceStack/Stripe/blob/master/src/Stripe/StripeGateway.cs

should probably catch exceptions (in those sections that throw them, these seem to be a bit mix-n-match in terms of failing silently vs throwing webexceptions), and wrap into an Intrinio-specfic exception wrapper, similar to the stripe example?

Or possibly simply catch and return empty response objects, so that ALL api wrapper calls shouldnt throw exceptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant