Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrlr window not showing up in Ableton Live #36

Open
damiensellier opened this issue Aug 18, 2024 · 5 comments
Open

Ctrlr window not showing up in Ableton Live #36

damiensellier opened this issue Aug 18, 2024 · 5 comments
Labels
test test required before closing

Comments

@damiensellier
Copy link
Owner

Ctrlr window is not showing up in Ableton Live. (Reported by @dobo365)

Related files :

https://github.com/damiensellier/CtrlrX/blob/master/Source/Plugin/CtrlrProcessorEditorForLive.cpp
https://github.com/damiensellier/CtrlrX/blob/master/Source/Plugin/CtrlrProcessorEditorForLive.h

@damiensellier
Copy link
Owner Author

The container component probably needs a addAndMakeVisible() declaration.

addAndMakeVisible(CtrlrEditorWrapper = new CtrlrEditorWrapper(*this));

ou
addAndMakeVisible(CtrlrEditorWrapper);

@dobo365
Copy link
Collaborator

dobo365 commented Aug 19, 2024

Please note that not all users have this issue so, not sure...
For me it works fine in my versions of Ableton Live Lite. It must work fine for other users of the full version.
But we can indeed try. Will be difficult to test a problem that I don't have ;-)
I can always send another version to the user with the issue...

@damiensellier
Copy link
Owner Author

Okay je pensais que c'était généralisé. Alors là ça devient compliqué.
Je peux le rajouter pour voir si ça marche quand même ça n'engage à rien.

@damiensellier
Copy link
Owner Author

CtrlrProcessorEditorForLive.cpp

CtrlrEditorWrapper::CtrlrEditorWrapper(CtrlrProcessorEditorForLive &_liveEditorOwner, CtrlrProcessor *ownerFilter, CtrlrManager &ctrlrManager) 
	: DocumentWindow("Ctrlr", Colours::lightgrey, 0, true), liveEditorOwner(_liveEditorOwner)
{
	setTitleBarHeight(1);
    editor = new CtrlrEditor(ownerFilter, ctrlrManager);
    addAndMakeVisible(editor); // Added v5.6.31. Force wrapper visibility
	setContentOwned (editor, true);
	setAlwaysOnTop(true);
	centreWithSize (getWidth(),getHeight());
}

Also relies on property "Use the Editor Wrapper for VST Plugins"

@damiensellier
Copy link
Owner Author

NOTE : Please check update with LIVE ABLETON 12 FULL and LITE version

@damiensellier damiensellier added the test test required before closing label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test test required before closing
Projects
None yet
Development

No branches or pull requests

2 participants