Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

childWindow (Console window & Midi Monitor...) menu File/View>Close won't work or crash #38

Open
damiensellier opened this issue Dec 5, 2024 · 4 comments

Comments

@damiensellier
Copy link
Owner

damiensellier commented Dec 5, 2024

Console crashes Cubase and standalone if window is closed from the Menu File>Close
But it does not crash if closed from the top corner close x button

Console crash CTRLRX

Capture d’écran 2024-12-05 à 21 03 43
@damiensellier damiensellier changed the title Console window crashes Cubase if window is closed from the Menu File>Close Console window crashes Cubase if closed from the Menu File>Close Dec 5, 2024
@damiensellier
Copy link
Owner Author

Same for CtrlrMIDIMonitor.cpp Close option not assigned

	if (topLevelMenuIndex == 0 && menuItemID==1)
	{
		// close handle
	}

Look for :
// close handle

@damiensellier damiensellier changed the title Console window crashes Cubase if closed from the Menu File>Close Console window & Midi Monitor crashing Cubase if closed from the Menu File>Close Dec 10, 2024
@damiensellier
Copy link
Owner Author

damiensellier commented Dec 10, 2024

CtrlrChildWindowContainer.cpp L156

void CtrlrChildWindowContainer::menuItemSelected(int menuItemID, int topLevelMenuIndex)
{
    if (topLevelMenuIndex == 0 && menuItemID==1)
    {
        // close handle
    }
    else if (content)
	{
		content->menuItemSelected(menuItemID, topLevelMenuIndex);
	}
}

@damiensellier
Copy link
Owner Author

damiensellier commented Dec 10, 2024

toggle() function to close window uses

windows.removeObject (w);

to show window :

		w->setVisible (true);
		w->toFront (true);

removeObject() crashes on some window : console and midi monitor

name for different windows with toggle()


class CtrlrPanelWindowManager : public CtrlrWindowManager
{
	public:
		enum WindowType
		{
			LuaConsole,
			LuaMethodEditor,
			ModulatorList,
			LayerEditor,
			MIDILibrary,
			MIDISettings
		};

@damiensellier
Copy link
Owner Author

Problematic close menuItem have been removed from File or View Menus (CtrlrLuaConsole & CtrlrMidiMonitor) but the default close menuItem from CtrlrChildWindowContainer.cpp L156 is still unconnected to a close handle function.

@damiensellier damiensellier changed the title Console window & Midi Monitor crashing Cubase if closed from the Menu File>Close childWindow (Console window & Midi Monitor...) menu File/View>Close won't work or crash Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant