Cleanup #195
Closed
Cleanup #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #194 |
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
=========================================
Coverage 84.95% 84.95%
Complexity 789 789
=========================================
Files 95 95
Lines 2552 2552
Branches 150 150
=========================================
Hits 2168 2168
Misses 328 328
Partials 56 56Continue to review full report at Codecov.
|
dancancro
reviewed
Aug 20, 2017
There was a problem hiding this comment.
Hi Moshe, did you run the tests with this? This line in karma.conf.js looks weird https://github.com/dancancro/great-big-example-application/pull/195/files#diff-e503c362c04aba5b3ad3d08476f678b6R5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.