Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report warnings and errors first #62

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

odenbach
Copy link
Contributor

Hi again,

this pull request is all about minimizing the plugin output to focus the admin onto the problem. It changes quite a lot, so I would like to comment on the different commits:

  • (the new option --mem-modules from my previous pull request)
  • raise_alert() is now called once for every hardware. This makes it a lot easier to collect every single warning message to be able to display it accordingly.
  • output now occurs only after every single item has been checked. Then critical or warning messages are printed before everything else (which can additionally be suppressed by the --quiet switch).
  • I added a --debug switch to quickly enable additional output without having to edit the source.
  • the disk attribute "isFailing" was not chosen wisely: snmpget does not translate the boolean value 0 or 1 to anything readable. So I translated 0 to 'ok' which is included in the default ok-list.
  • Just as in issue ROMB Battery returns value of 0 or 2147483648 when not available #12 our R320 servers also return -2147483648 for non-existing batteries. So I translated this value to '(n/a)' which works perfectly.

If you have any questions please let me know.

Cheers,

Christopher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant