convert from using moment.js to dayjs.js

[morrow95]

Anyone attempt to do this? I'd like to switch my site from using moment to dayjs since moment is 'done' (https://momentjs.com/docs/#/-project-status/).

The core dayjs won't cut it, but there are a bunch of plugins available and it very closely resembles moment in terms of calls. I just started to mess around with this and slowly going through all the calls to moment in the daterangepicker.js, but it appears to be going well. Right now populating the calendars is the only problem I am having as everything is coming up NaN.

I'm going to mess around with this more, but just wondering if anyone else already did this or there is a fork somewhere to save me some time.

[dangrossman]

There's a pull request you can check out to see if they've already done the work: #2354

[morrow95]

Found someone who did exactly this... seems to be working great too. @dangrossman I don't know if you even look at this anymore, but you might want to consider offering the option for using dayjs - would be trivial to do considering the work is already done with the fork.

https://github.com/iamkumaran/daterangepicker-dayjs

[morrow95]

Played around with this last night and it works with daterangepicker fine. What I did not expect is there are tons of wrong results being produced with dayjs depending on how you use it. In my situation, I am performing a lot of timezone parsing/formatting and dayjs is severely lacking in this department - plenty of bug reports can be found about it. If you are just doing the barebones stuff it works fine, but once you start using the timezone plugin and other stuff with your values you can expect wrong results. This is a dealbreaker for me as I must have correct results and be able to rely on those results.

I took a look at luxon, but it honestly doesn't seem to be worth it in terms of size and performance. Date-fns seems to be the recommended solution so will be looking into that today.