Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change email doesn't show errors #5630

Open
SaadBazaz opened this issue Feb 21, 2025 · 2 comments
Open

Change email doesn't show errors #5630

SaadBazaz opened this issue Feb 21, 2025 · 2 comments
Labels
enhancement New feature or request low priority Won't fix anytime soon, but will accept PR if provided

Comments

@SaadBazaz
Copy link

Vaultwarden Support String

Can't obtain, idk

Vaultwarden Build Version

Latest as of the date this issue was created

Deployment method

Official Container Image

Custom deployment method

I'm using it through Coolify, as a One-Click service

Reverse Proxy

Traefix

Host/Server Operating System

Linux

Operating System Version

Ubuntu Server 24

Clients

Web Vault

Client Version

No idea

Steps To Reproduce

(Pre-setup)

  1. Go to Admin Console of your VaultWarden instance
  2. Invite a user, let's say "[email protected]"
  3. This user has NOT joined VaultWarden yet

Test repro:
You are currently "[email protected]"

  1. Go to your Settings -> My account
  2. Under "Change Email", Enter Master code
  3. Enter New Email -> "[email protected]"

Expected Result

It should ideally show:
"This email is already in use. Please try a different email."
Or something similar. Or at least throw a 500 unknown error.

Actual Result

It silently fails, even though Network tab shows a 400 request error.

Logs


Screenshots or Videos

Screen.Recording.2025-02-21.at.18.15.47.mp4

Additional Context

No response

@SaadBazaz SaadBazaz added the bug Something isn't working label Feb 21, 2025
@BlackDex
Copy link
Collaborator

It seems to work fine for me.
And, if you were able to login using that password, you should also be able to use this form, the exact same function is used to check and validate the password.

@BlackDex
Copy link
Collaborator

Ah wait, the message is not shown indeed. But that isn't something we can fix I'm afraid.
The web-vault (client) is not something we develop or maintain.

We actually should mimic Bitwarden, and still send an email to the mail address entered and explain the action done, and still return a 200. Which would still not solve the error part, but that way of working seems a bit better.

@BlackDex BlackDex added enhancement New feature or request low priority Won't fix anytime soon, but will accept PR if provided and removed bug Something isn't working labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority Won't fix anytime soon, but will accept PR if provided
Projects
None yet
Development

No branches or pull requests

2 participants