You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
we are using your release plugin, and it works like a charm. Something which I think is missing is the handling of plugin dependencies. Example:
Module xxx-openapi-spec
Module xxx-service
The service module xxx-sevices has a dependency to the xxx-openapi-spec module, and it has the same dependency in the openapi-generator plugin, so that the plugin has the xxx-openapi-spec in the classpath (and can generate source from the openapi-spec). The generator plugin configuration looks like this:
As you can see, there is a SNAPSHOT version in the plugin-dependency, and plugin-dependencies are not automatically updated with your plugin when releasing. So we end up with a SNAPSHOT version in the release, which fails the release build.
I checked the source code it would be quite simple to do a PR which would include handling plugin dependencies.
What do you think about this feature? I am happy to make a PR.
Thanks a lot & Cheers
Michael
The text was updated successfully, but these errors were encountered:
Hi Daniel,
we are using your release plugin, and it works like a charm. Something which I think is missing is the handling of plugin dependencies. Example:
The service module xxx-sevices has a dependency to the xxx-openapi-spec module, and it has the same dependency in the openapi-generator plugin, so that the plugin has the xxx-openapi-spec in the classpath (and can generate source from the openapi-spec). The generator plugin configuration looks like this:
<plugin> <groupId>org.openapitools</groupId> <artifactId>openapi-generator-maven-plugin</artifactId> <dependencies> <dependency> <groupId>xxx-group-id</groupId> <artifactId>xxx-openapi-spec</artifactId> <version>0.6-SNAPSHOT</version> </dependency>
As you can see, there is a SNAPSHOT version in the plugin-dependency, and plugin-dependencies are not automatically updated with your plugin when releasing. So we end up with a SNAPSHOT version in the release, which fails the release build.
I checked the source code it would be quite simple to do a PR which would include handling plugin dependencies.
What do you think about this feature? I am happy to make a PR.
Thanks a lot & Cheers
Michael
The text was updated successfully, but these errors were encountered: