Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin dependencies #145

Open
msaladin opened this issue Nov 1, 2024 · 1 comment
Open

Update plugin dependencies #145

msaladin opened this issue Nov 1, 2024 · 1 comment

Comments

@msaladin
Copy link
Contributor

msaladin commented Nov 1, 2024

Hi Daniel,

we are using your release plugin, and it works like a charm. Something which I think is missing is the handling of plugin dependencies. Example:

  • Module xxx-openapi-spec
  • Module xxx-service

The service module xxx-sevices has a dependency to the xxx-openapi-spec module, and it has the same dependency in the openapi-generator plugin, so that the plugin has the xxx-openapi-spec in the classpath (and can generate source from the openapi-spec). The generator plugin configuration looks like this:

<plugin> <groupId>org.openapitools</groupId> <artifactId>openapi-generator-maven-plugin</artifactId> <dependencies> <dependency> <groupId>xxx-group-id</groupId> <artifactId>xxx-openapi-spec</artifactId> <version>0.6-SNAPSHOT</version> </dependency>

As you can see, there is a SNAPSHOT version in the plugin-dependency, and plugin-dependencies are not automatically updated with your plugin when releasing. So we end up with a SNAPSHOT version in the release, which fails the release build.

I checked the source code it would be quite simple to do a PR which would include handling plugin dependencies.

What do you think about this feature? I am happy to make a PR.

Thanks a lot & Cheers
Michael

@danielflower
Copy link
Owner

Hi Michael, yes I think that makes sense. Feel free to make a pull request. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants