dep(nbconvert): major version upgrade #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 28, 2023 18:58
- include new lock file to record total dependency changes for poetry required as part of major upgrade
…akpoint debugging
josephmcasey
commented
Mar 1, 2023
mkdocs_jupyter/nbconvert2.py
Outdated
Comment on lines
251
to
253
| return MarkdownWithMath( | ||
| renderer=CustomMarkdownRendered(escape=False) | ||
| ).render(source) |
There was a problem hiding this comment.
style(fmt): changes produced by fmt cmd in Taskfile.yml
josephmcasey
commented
Mar 1, 2023
| @@ -117,7 +117,7 @@ | |||
|
|
|||
| # %% | |||
| x = linspace(0, 5, 10) | |||
| y = x ** 2 | |||
| y = x**2 | |||
There was a problem hiding this comment.
style(fmt): changes produced by fmt cmd in Taskfile.yml
josephmcasey
commented
Mar 1, 2023
| config_file = os.path.join(this_dir, f"mkdocs/{filename}") | ||
|
|
||
| try: | ||
| build(load_config(config_file)) |
There was a problem hiding this comment.
test(renders): replaces subprocess to better enable hot-reloading breakpoint debugging
josephmcasey
commented
Mar 1, 2023
pyproject.toml
Outdated
| @@ -22,7 +22,7 @@ include = ["mkdocs_jupyter/**/assets/*"] | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = ">=3.7.1,<4" | |||
| nbconvert = "^6.2.0" | |||
| nbconvert = "^7.2.9" | |||
There was a problem hiding this comment.
dep(nbconvert): upgrade nbconvert 6.5.0 to 7.2.9
josephmcasey
commented
Mar 1, 2023
mkdocs_jupyter/nbconvert2.py
Outdated
| def custom_clean_html(element): | ||
| return element.decode() if isinstance(element, bytes) else str(element) | ||
|
|
||
| default_filters["clean_html"] = custom_clean_html |
There was a problem hiding this comment.
fix(nbconvert2): monkey patch partially functional clean_html
josephmcasey
commented
Mar 1, 2023
poetry.lock
Outdated
|
|
||
| [[package]] | ||
| name = "nbconvert" | ||
| version = "6.5.0" | ||
| version = "7.2.9" |
There was a problem hiding this comment.
build(poetry.lock): refresh file hashes with poetry v1.4.0
|
Thank you so much for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dep/nbconvertResolves #121
Resolves #126
Resolves #109
Changelog Details
Resources