Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MSK IAM SASL mechanism ? #380

Open
ankush-custiv opened this issue Apr 11, 2023 · 3 comments
Open

Support MSK IAM SASL mechanism ? #380

ankush-custiv opened this issue Apr 11, 2023 · 3 comments

Comments

@ankush-custiv
Copy link

The exporter currently cannot connect to AWS MSK with the IAM SASL mechanism, which is also the recommended way to connect to MSK. Using IAM mechanism, we will only require AWS_SECRET_ACCESS_KEY & AWS_ACCESS_KEY_ID to connect to MSK. Please let us know if it will be supported in future.

@jclRatepay
Copy link

I am also very interested in this feature as we would like to make use of the kafka_exporter to get the metrics off of our AWS MSK clusters. I had a first look into the required changes my self - and am afraid that I guess it won't be so easy to achieve (need to mention that I have only poor golang experience yet). The kafka_exporter is making use of "sarama" as a Kafka Client which does not support MSK IAM SASL mechanism yet. There exist issues for implementing this in the client (see e.g. IBM/sarama#1985) which also seemed to be worked on, but this will be some kind of prerequisite before being able to implement that support here, and going through the sarama-library issues they seem to face some problems there.....

@ankush-custiv
Copy link
Author

@jclRatepay Right, to support this feature, kafka_exporter must move to "kafka-go"(https://github.com/segmentio/kafka-go) instead of "sarama", atleast that's what we did at our org to use IAM SASL mechanism. There are many other benefits to using kafka-go over sarama & other kafka client libs, which are mentioned on their README. However, I'd wait for @danielqsj's feedback before going in this direction.

@troyApart
Copy link

troyApart commented Jul 23, 2024

There is now a sarama supported solution: https://github.com/aws/aws-msk-iam-sasl-signer-go
I also see an open PR related: #415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants