From 7537a4f5d49359090d5a5c70dc9768bbb963e827 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Est=C3=A9vez?= Date: Mon, 8 Apr 2024 16:10:12 +0200 Subject: [PATCH] fix build error with crc-3.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In crc-3.2.0 the crc::Digest struct that we use is no longer Clone. This is because it has gained an extra type parameter Implementation that defaults to Table<1>, which does not implement Clone. This breaks dvb-gse, because the struct Defrag, which includes a crc::Digest, was deriving Clone. Since Defrag is a private struct and the fact that it is Clone is not exposed in the API (it is only included in GSEPacketDefrag, which is not Clone), we can simply remove the derive Clone from Defrag to fix this problem. Signed-off-by: Daniel Estévez --- CHANGELOG.md | 11 +++++++++-- Cargo.toml | 2 +- src/gsepacket.rs | 1 - 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d21c2bd..721aa35 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +## [0.6.1] - 2024-04-08 + +### Fixed + +- Build error with crc-3.2.0. + ## [0.6.0] - 2023-12-12 ### Added @@ -107,8 +113,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Initial release. -[unreleased]: https://github.com/daniestevez/dvb-gse/compare/v0.6.0...HEAD -[0.5.0]: https://github.com/daniestevez/dvb-gse/compare/v0.5.0...v0.6.0 +[unreleased]: https://github.com/daniestevez/dvb-gse/compare/v0.6.1...HEAD +[0.6.1]: https://github.com/daniestevez/dvb-gse/compare/v0.6.0...v0.6.1 +[0.6.0]: https://github.com/daniestevez/dvb-gse/compare/v0.5.0...v0.6.0 [0.5.0]: https://github.com/daniestevez/dvb-gse/compare/v0.4.4...v0.5.0 [0.4.4]: https://github.com/daniestevez/dvb-gse/compare/v0.4.3...v0.4.4 [0.4.3]: https://github.com/daniestevez/dvb-gse/compare/v0.4.2...v0.4.3 diff --git a/Cargo.toml b/Cargo.toml index e825cac..a3d069b 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "dvb-gse" -version = "0.6.0" +version = "0.6.1" edition = "2021" authors = ["Daniel Estevez "] description = "DVB-GSE (Digital Video Brodcast Generic Stream Encapsulation)" diff --git a/src/gsepacket.rs b/src/gsepacket.rs index 8650040..813df95 100644 --- a/src/gsepacket.rs +++ b/src/gsepacket.rs @@ -125,7 +125,6 @@ pub struct GSEPacketDefrag { skip_total_length_check: bool, } -#[derive(Clone)] struct Defrag { total_length: usize, protocol_type: u16,