Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUGGESTION] Rename HAIntegration::configure() to either HAIntegration::begin() or HAIntegration::setup() #16

Open
JacobChrist opened this issue Nov 5, 2023 · 1 comment

Comments

@JacobChrist
Copy link

Rename HAIntegration::configure() to either HAIntegration::begin() or HAIntegration::setup() for more orthogonal naming with the Wiring/Arduino naming conventions.

I feel like begin() better matches other Arduino classes in how its used, but because of the loop() it really feels like it should be called setup().

Frankly, configure() doesn't really bother me either, but I think begin() or setup() really hits home as to what this function is doing and where it probably should be called from.

@JacobChrist JacobChrist changed the title [SUGGESTION] [SUGGESTION] Rename HAIntegration::configure() to either HAIntegration::begin() or HAIntegration::setup() Nov 5, 2023
@daniloc
Copy link
Owner

daniloc commented Nov 5, 2023

Yeah, thanks for thinking about this, I agree. begin() is probably the most culturally idiomatic. You've got a few thoughts brewing, want to open a PR to reflect this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants