You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Rename HAIntegration::configure() to either HAIntegration::begin() or HAIntegration::setup() for more orthogonal naming with the Wiring/Arduino naming conventions.
I feel like begin() better matches other Arduino classes in how its used, but because of the loop() it really feels like it should be called setup().
Frankly, configure() doesn't really bother me either, but I think begin() or setup() really hits home as to what this function is doing and where it probably should be called from.
The text was updated successfully, but these errors were encountered:
JacobChrist
changed the title
[SUGGESTION]
[SUGGESTION] Rename HAIntegration::configure() to either HAIntegration::begin() or HAIntegration::setup()
Nov 5, 2023
Yeah, thanks for thinking about this, I agree. begin() is probably the most culturally idiomatic. You've got a few thoughts brewing, want to open a PR to reflect this change?
Rename HAIntegration::configure() to either HAIntegration::begin() or HAIntegration::setup() for more orthogonal naming with the Wiring/Arduino naming conventions.
I feel like begin() better matches other Arduino classes in how its used, but because of the loop() it really feels like it should be called setup().
Frankly, configure() doesn't really bother me either, but I think begin() or setup() really hits home as to what this function is doing and where it probably should be called from.
The text was updated successfully, but these errors were encountered: