Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): optionable remarkable #417

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mte90
Copy link

@Mte90 Mte90 commented Jan 31, 2024

Ref #414

On my tests seems working.

@danirus
Copy link
Owner

danirus commented Feb 1, 2024

This PR doesn't address the issue you have reported. The problem is that you are not loading remarkable, and the wrapper created by Rollupjs can't use it.

@Mte90
Copy link
Author

Mte90 commented Feb 1, 2024

Is optional as if I don't load the library in the page there isn't any error and the library works without issues.
So it is optional as it is not needed anymore to run this project, uses it only if find it in the page.

@danirus
Copy link
Owner

danirus commented Feb 12, 2024

My comment in the PR #420 also applies here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants