Fix timeout issue

danitso · Mar 15, 2020 · 913580b · 913580b
1 parent 097e3bf
commit 913580b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,6 +18,7 @@ BUG FIXES:
 * resource/virtual_environment_vm: Fix `network_device` deletion issue
 * resource/virtual_environment_vm: Fix slow refresh when VM is stopped and agent is enabled
 * resource/virtual_environment_vm: Fix crash caused by assuming IP addresses are always reported by the QEMU agent
+* resource/virtual_environment_vm: Fix timeout issue while waiting for IP addresses to be reported by the QEMU agent
 
 OTHER:
 

diff --git a/proxmox/virtual_environment_vm.go b/proxmox/virtual_environment_vm.go
@@ -154,7 +154,7 @@ func (c *VirtualEnvironmentClient) WaitForNetworkInterfacesFromVMAgent(nodeName
 
 				if waitForIP {
 					for _, nic := range *data.Result {
-						if nic.IPAddresses == nil {
+						if nic.IPAddresses != nil && len(*nic.IPAddresses) == 0 {
 							missingIP = true
 							break
 						}

diff --git a/proxmox/virtual_environment_vm_types.go b/proxmox/virtual_environment_vm_types.go
@@ -301,7 +301,7 @@ type VirtualEnvironmentVMGetQEMUNetworkInterfacesResponseData struct {
 type VirtualEnvironmentVMGetQEMUNetworkInterfacesResponseResult struct {
 	MACAddress  string                                                                 `json:"hardware-address"`
 	Name        string                                                                 `json:"name"`
-	Statistics  VirtualEnvironmentVMGetQEMUNetworkInterfacesResponseResultStatistics   `json:"statistics"`
+	Statistics  *VirtualEnvironmentVMGetQEMUNetworkInterfacesResponseResultStatistics  `json:"statistics,omitempty"`
 	IPAddresses *[]VirtualEnvironmentVMGetQEMUNetworkInterfacesResponseResultIPAddress `json:"ip-addresses,omitempty"`
 }