Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to add lock information to PROPFIND response #1096

Open
michalhorcic opened this issue Mar 5, 2020 · 1 comment
Open

Possibility to add lock information to PROPFIND response #1096

michalhorcic opened this issue Mar 5, 2020 · 1 comment

Comments

@michalhorcic
Copy link

When asking webdav for file information with PROPFIND is it possible to include information about existing lock in XML response?

My goal is to be able to display lock information in webdav clients (like WinSCP).

With some hacky changes in the code, I am somewhat able to add it there myself, but before going deeper into the code and changing things that I am not expert on. I want to ask if there is a reason why lock information is not included in PROPFIND response or if anybody was dealing with similar issue.

@picman
Copy link
Collaborator

picman commented Mar 17, 2020

Yes, it seems that the response to a PROPFIND request misses lockdiscovery field. I think that the part related to lockdiscovery shoul be copied from lock method to propfind in lib/dav4rack/controller.rb. But dav4rack is an external library copied from https://github.com/planio-gmbh/dav4rack an locally stored in this plugin. The right way would be to inherit Controller class in DMSF the same way as e.g. ResourceProxy class and write there a new implementation of propfind method. Try it and make a pull request here together with integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants