Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registrar has begun accepting parenthetical requisite style for classes #27

Open
dannybd opened this issue May 3, 2018 · 0 comments
Open
Labels

Comments

@dannybd
Copy link
Owner

dannybd commented May 3, 2018

The MIT Registrar defines a strict syntax for course requisites. It's the adherence to this strictness which has made CourseRoad possible, by allowing the automated parsing of those requirements.

Starting in Spring 2018, some classes began using an alternate syntax for their requisites, which relies on the use of nested parentheses. Example: (6.041B, 18.05, or 18.600) and (18.06, 18.700, or 18.701)

parseRequisites, whose core logic hasn't really changed since the initial commit in May 2012, doesn't know what to do with this, and is incorrectly parsing the parentheses as part of the course names. This is causing breakage downstream, as the prereq-line-drawing UI code tries to find classes with invalid names.

9b6a5fb patched this to prevent said UI breakage but we'll need to write a better requisite parser than whatever freshman!Danny could manage in 2012 :P

@dannybd dannybd added the bug label May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant