Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments on large diffs are not accepted #13

Open
drahnr opened this issue Aug 19, 2022 · 1 comment
Open

Comments on large diffs are not accepted #13

drahnr opened this issue Aug 19, 2022 · 1 comment

Comments

@drahnr
Copy link
Contributor

drahnr commented Aug 19, 2022

> diff --git a/foo.json b/foo.json
> deleted file mode 100644
> index f132fcb..0000000
> --- a/foo.json
> +++ /dev/null
> @@ -1,150 +0,0 @@

Please don't delete this mingled with other changes in the same PR

> -{
> -  "name": "baz",
> -  "id": "bar",
> -  "properties": null,
// many more lines
Error: Error during POST: Status code: 422 Unprocessable Entity, Body: {"message":"Unprocessable Entity","errors":["Pull request review thread path diff too large and Pull request review thread diff hunk can't be blank"],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-review-for-a-pull-request"}
@drahnr drahnr changed the title Line 0 comments for deleted files cause errors Comments on large diffs are not accepted Aug 19, 2022
@danobi
Copy link
Owner

danobi commented Aug 19, 2022

When I try leaving a comment on the 0 line I get this error:

Error: Error during POST: Status code: 422 Unprocessable Entity, Body: {"message":"Unprocessable Entity","errors":["Pull request review thread line required and an integer greater than zero and Pull request review thread diff hunk can't be blank"],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-review-for-a-pull-request"}

which is different than your error.

Maybe GH has limitations on which files can be commented on? eg for too large of diffs? Not sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants