Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignored paths regression in prr-apply dirty check #50

Open
danobi opened this issue Jan 9, 2024 · 1 comment
Open

Fix ignored paths regression in prr-apply dirty check #50

danobi opened this issue Jan 9, 2024 · 1 comment

Comments

@danobi
Copy link
Owner

danobi commented Jan 9, 2024

0889e77 regressed dirty checks. I think we want to bring back status_opts.include_ignored(false);.

Regression (with some debug info):

$ git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean
$ ./target/debug/prr apply 47
".prr.toml": Status(IGNORED)
".prr/": Status(IGNORED)
".tags": Status(IGNORED)
"target/": Status(IGNORED)
Error: Working directory is dirty

Fix should come with a unit test. We can use libgit2 to init a repo in a temp dir

@danobi
Copy link
Owner Author

danobi commented Jan 18, 2024

Looks like we also need to strip out PR description if it exists. If there were tests for prr-apply we probably wouldn't have regressed :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant