DDBTEAM-538: Added test for multiple allowed client id's

danskernesdigitalebibliotek · Jun 26, 2020 · df50eab · df50eab
1 parent 7100676
commit df50eab
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/Security/TokenAuthenticator.php b/src/Security/TokenAuthenticator.php
@@ -58,7 +58,8 @@ public function __construct(string $openplatformId, string $openplatformSecret,
         $this->clientId = $openplatformId;
         $this->clientSecret = $openplatformSecret;
         $this->endPoint = $openplatformIntrospectionUrl;
-        $this->allowedClients = empty($openplatformAllowedClients) ? [] : explode(',', $openplatformAllowedClients);
+
+        $this->allowedClients = empty($openplatformAllowedClients) ? [] : array_map('trim', explode(',', $openplatformAllowedClients));
 
         $this->client = $httpClient;
         $this->cache = $tokenCache;

diff --git a/tests/TokenAuthenticatorTest.php b/tests/TokenAuthenticatorTest.php
@@ -287,14 +287,14 @@ public function testActiveUSerAllowed(): void
      */
     public function testCachedTokensClientIsAllowed(): void
     {
-        $this->tokenAuthenticator = $this->getTokenAuthenticator('allowed-client-id');
+        $this->tokenAuthenticator = $this->getTokenAuthenticator('allowed-client-id-1, allowed-client-id-2, allowed-client-id-3');
 
         $this->cache->method('getItem')->willReturn($this->item);
         $this->cache->expects($this->once())->method('getItem')->with('12345678');
 
         $this->item->method('isHit')->willReturn(true);
         $user = new User();
-        $user->setClientId('allowed-client-id');
+        $user->setClientId('allowed-client-id-2');
         $expires = new \DateTime('now + 2 days', new \DateTimeZone('UTC'));
         $user->setExpires($expires);
         $this->item->method('get')->willReturn($user);