Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor content-list-item__description #622

Merged
merged 1 commit into from
May 14, 2024

Conversation

kasperbirch1
Copy link
Contributor

@kasperbirch1 kasperbirch1 commented May 3, 2024

Depend on:

https://reload.atlassian.net/browse/DDFFORM-753
danskernesdigitalebibliotek/dpl-cms#1055

Description

Remove unnecessary p tag and set margin back to default auto, which is needed for the truncate to work properly.

@kasperbirch1 kasperbirch1 force-pushed the fix-event-description-truncate-2 branch from 0f1e1d2 to 0b055bd Compare May 3, 2024 13:28
Remove unnecessary `p` tag and set margin-bottom  back to default `auto`, which is needed for the truncate to work properly.
@kasperbirch1 kasperbirch1 force-pushed the fix-event-description-truncate-2 branch from 0b055bd to e9122cd Compare May 3, 2024 13:29
Copy link
Contributor

@LasseStaus LasseStaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@LasseStaus LasseStaus assigned kasperbirch1 and unassigned LasseStaus May 7, 2024
@kasperbirch1 kasperbirch1 removed their assignment May 7, 2024
@kasperbirch1 kasperbirch1 merged commit 5e61f7d into release/hermod-14 May 14, 2024
8 checks passed
@kasperbirch1 kasperbirch1 deleted the fix-event-description-truncate-2 branch May 14, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants