Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Material types in singular #81

Merged
merged 14 commits into from
Dec 20, 2024
Merged

Material types in singular #81

merged 14 commits into from
Dec 20, 2024

Conversation

Adamik10
Copy link
Contributor

Link to issue

https://reload.atlassian.net/browse/DDFBRA-253

Description

This PR:

  • shows material types in SlideSelect in singular
  • shows material types in Details info box in singular
  • shows a dash "-" for empty values for improved UX
  • shows contributors in work page header in case work creators aren't defined

Screenshot of the result

image
image
image

Additional comments or questions

@Adamik10
Show a dash if InfoBoxItem data is empty
31d5623
@Adamik10
Add material type translations for various media formats
a0a4104
@Adamik10
Add translation function for material types in SlideSelectOption
2730160
@Adamik10
Add function to translate material types in InfoBox helper
93787cf
@Adamik10
Increase minimum width of SlideSelect options for better visibility
b33c482
@Adamik10
Refactor WorkPageHeader to use materialTypes directly and add transla…
0f67d68 
…tion for unique material types in slide select options
@Adamik10
Show singular material types in Details box & a dash when no data is …
9e2ed99 
…present
@Adamik10
Show a dash if no data in description InfoBox
0354fe7
@Adamik10
Update displayCreators function to support multiple creator types and…
b5b636f 
… prevent duplicate entries
@Adamik10
Update WorkPageHeader to display contributors when creators are unava…
4afdd08 
…ilable
@ThomasGross ThomasGross self-requested a review December 19, 2024 14:16
ThomasGross
ThomasGross approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@ThomasGross ThomasGross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good i have a few comments to consider

components/shared/workCard/helper.ts Show resolved Hide resolved
components/shared/workCard/helper.ts Outdated Show resolved Hide resolved
@Adamik10 Adamik10 merged commit 84046c2 into main Dec 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasGross ThomasGross ThomasGross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Adamik10 @ThomasGross @spaceo @Dresse @JacobArrow @kasperbirch1