Skip to content

Commit

Permalink
Use unique artifact name for videos and screenshots
Browse files Browse the repository at this point in the history
After updating to actions/upload-artifact@v4 multiple artifacts cannot
share the same name. This makes the job fail.

Add the container id to the artifact name to ensure uniqueness.

See
https://github.com/actions/upload-artifact#not-uploading-to-the-same-artifact
  • Loading branch information
kasperg committed Dec 28, 2023
1 parent 619179a commit 19e74f2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,13 @@ jobs:
uses: actions/upload-artifact@v4
if: failure()
with:
name: cypress-screenshots
name: cypress-screenshots-${{ matrix.containers }}
path: cypress/screenshots
- name: Upload videos
uses: actions/upload-artifact@v4
if: always()
with:
name: cypress-videos
name: cypress-videos-${{ matrix.containers }}
path: cypress/videos
- name: Generate code coverage report
run: yarn run nyc report --reporter=clover --reporter=text --report-dir=./coverage
Expand Down

0 comments on commit 19e74f2

Please sign in to comment.