Merge branch 'master' into unstable

# Conflicts:
#	CHANGELOG.md
#	pubspec.yaml

Author: danvick

CHANGELOG.md

@@ -1,3 +1,10 @@
+## [1.9.0-dev.3] - 15-Jun-2020
+* Added fixes from v1.8.3
+
+## [1.8.3] - 15-Jun-2020
+* Fixed bug in checking whether `maxChips` has been reached.
+* Fix `setState called on disposed widget`
+
 ## [1.9.0-dev.2] - 14-Jun-2020
 * Merged in changes from v1.8.2
 

README.md

@@ -7,6 +7,8 @@ Flutter library for building input fields with InputChips as input options.
 ### Installation
 Follow installation instructions [here](https://pub.dartlang.org/packages/flutter_chips_input#-installing-tab-)
 
+**NOTE:** For anyone on pre-release Flutter channels, kindly prefer the [pre-release versions of the package](https://pub.dev/packages/flutter_chips_input/versions#prerelease).
+
 ### Import
 ```dart
 import 'package:flutter_chips_input/flutter_chips_input.dart';

example/lib/main.dart

@@ -71,10 +71,10 @@ class _MyHomePageState extends State<MyHomePage> {
               TextField(),
               ChipsInput(
                 key: _chipKey,
-                initialValue: [
+                /*initialValue: [
                   AppProfile('John Doe', '[email protected]',
                       'https://d2gg9evh47fn9z.cloudfront.net/800px_COLOURBOX4057996.jpg'),
-                ],
+                ],*/
                 // autofocus: true,
                 // allowChipEditing: true,
                 keyboardAppearance: Brightness.dark,

lib/src/chips_input.dart

@@ -113,7 +113,7 @@ class ChipsInputState<T> extends State<ChipsInput<T>>
       _textInputConnection != null && _textInputConnection.attached;
 
   bool get _hasReachedMaxChips =>
-      (widget.maxChips != null && _chips.length < widget.maxChips);
+      widget.maxChips != null && _chips.length >= widget.maxChips;
 
   FocusAttachment _focusAttachment;
   FocusNode _focusNode;
@@ -153,9 +153,11 @@ class ChipsInputState<T> extends State<ChipsInput<T>>
       _closeInputConnectionIfNeeded();
       _suggestionsBoxController.close();
     }
-    setState(() {
-      /*rebuild so that _TextCursor is hidden.*/
-    });
+    if (mounted) {
+      setState(() {
+        /*rebuild so that _TextCursor is hidden.*/
+      });
+    }
   }
 
   void _initOverlayEntry() {
@@ -229,17 +231,19 @@ class ChipsInputState<T> extends State<ChipsInput<T>>
 
   void selectSuggestion(T data) {
     if (!_hasReachedMaxChips) {
+      _chips.add(data);
       if (widget.allowChipEditing) {
         var enteredText = _value.normalCharactersText ?? '';
         if (enteredText.isNotEmpty) _enteredTexts[data] = enteredText;
       }
-      _chips.add(data);
       _updateTextInputState(replaceText: true);
+
       _suggestions = null;
       _suggestionsStreamController.add(_suggestions);
       if (widget.maxChips == _chips.length) _suggestionsBoxController.close();
-    } else
+    } else {
       _suggestionsBoxController.close();
+    }
     widget.onChanged(_chips.toList(growable: false));
   }
 
@@ -271,9 +275,8 @@ class ChipsInputState<T> extends State<ChipsInput<T>>
     final localId = ++_searchId;
     final results = await widget.findSuggestions(value);
     if (_searchId == localId && mounted) {
-      _suggestions = results
-          .where((profile) => !_chips.contains(profile))
-          .toList(growable: false);
+      _suggestions =
+          results.where((r) => !_chips.contains(r)).toList(growable: false);
     }
     _suggestionsStreamController.add(_suggestions);
   }
@@ -325,6 +328,7 @@ class ChipsInputState<T> extends State<ChipsInput<T>>
         //composing: TextRange(start: 0, end: text.length),
       );
     });
+    print(_value);
 
     if (_textInputConnection == null) {
       _textInputConnection = TextInput.attach(this, textInputConfiguration);
@@ -410,7 +414,7 @@ class ChipsInputState<T> extends State<ChipsInput<T>>
                 maxLines: 1,
                 overflow: widget.textOverflow,
                 style: widget.textStyle ??
-                    theme.textTheme.subhead.copyWith(height: 1.5),
+                    theme.textTheme.subtitle1.copyWith(height: 1.5),
               ),
             ),
             Flexible(

pubspec.yaml

@@ -1,6 +1,6 @@
 name: flutter_chips_input
 description: Flutter library for building input fields with InputChips as input options.
-version: 1.9.0-dev.2
+version: 1.9.0-dev.3
 homepage: https://github.com/danvick/flutter_chips_input
 
 environment: