Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparation for logical structure #2353

Merged
merged 1 commit into from
Dec 24, 2020
Merged

Preparation for logical structure #2353

merged 1 commit into from
Dec 24, 2020

Conversation

Razzwan
Copy link
Contributor

@Razzwan Razzwan commented Dec 17, 2020

This is the first step Prepare redux store structure of implementation smart proposal serch from this steps

1. Prepare redux store structure

  1. Create reducer for storing proposals in the redux store
  2. Add browser cache to be able restore data from browser cache first
  3. Save proposals list to redux store and subscribe redux store to graphQL endpoints instead of subscribing each separate component
  4. Add lodash library to be able implement smart search by proposals using local storage first
  5. Test everything

@Razzwan Razzwan self-assigned this Dec 17, 2020
@Razzwan Razzwan linked an issue Dec 17, 2020 that may be closed by this pull request
Delay request and execute it after 2 seconds using lodash #2348
Open
@roienatan roienatan temporarily deployed to alchemy-preparation-for-zd1knd December 20, 2020 13:15 Inactive
@Razzwan Razzwan force-pushed the preparation-for-logical-structure branch from 8b58e40 to b893d1a Compare December 21, 2020 12:37
@orenyodfat orenyodfat temporarily deployed to alchemy-preparation-for-zd1knd December 21, 2020 12:37 Inactive
@Razzwan Razzwan force-pushed the preparation-for-logical-structure branch from b893d1a to 07bb487 Compare December 21, 2020 12:39
@orenyodfat orenyodfat temporarily deployed to alchemy-preparation-for-zd1knd December 21, 2020 12:39 Inactive
@Razzwan Razzwan force-pushed the preparation-for-logical-structure branch from 07bb487 to 5951405 Compare December 21, 2020 12:41
@orenyodfat orenyodfat temporarily deployed to alchemy-preparation-for-zd1knd December 21, 2020 12:41 Inactive
@Razzwan
fix: fix height of proposal form
7807cde 
feat: more clear redux store structure

fix: unit tests config

fix: removed useless aliases, which was moved to other folder
@Razzwan Razzwan force-pushed the preparation-for-logical-structure branch from 5951405 to 7807cde Compare December 23, 2020 16:47
@orenyodfat orenyodfat temporarily deployed to alchemy-preparation-for-zd1knd December 23, 2020 16:47 Inactive
@Razzwan Razzwan merged commit e85e6c7 into dev Dec 24, 2020
@roienatan roienatan deleted the preparation-for-logical-structure branch December 24, 2020 12:01
@Razzwan Razzwan mentioned this pull request Dec 24, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orenyodfat orenyodfat orenyodfat approved these changes

@roienatan roienatan Awaiting requested review from roienatan

Assignees

@Razzwan Razzwan

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delay request and execute it after 2 seconds using lodash
3 participants
@Razzwan @orenyodfat @roienatan