Creators Staking #155
Merged
Creators Staking #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix issue where useFetchCreator if fetched multiple times are calling upsert everytime, changing the state, even though the call to api is only once, making it infinite loop
olehmell
suggested changes
Dec 28, 2023
| @@ -99,14 +100,15 @@ const VoterButton = React.memo( | |||
| } | |||
|
|
|||
| let icon: JSX.Element | |||
| const label = preview || isMobile ? undefined : newKind | |||
| const labelText = isUpvote ? 'Like' : 'Dislike' | |||
There was a problem hiding this comment.
I refactored, so I remove the preview props, as we no longer use any actions with label
but the label itself I still keep it as the button title so the button can have built in tooltip
Co-authored-by: Oleh Mell <[email protected]>
…erse into deploy/creators
olehmell
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.