Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intentional use of accounting terms? #23

Open
charles-cooper opened this issue Mar 7, 2018 · 2 comments
Open

Intentional use of accounting terms? #23

charles-cooper opened this issue Mar 7, 2018 · 2 comments

Comments

@charles-cooper
Copy link

I'm wondering if the use of the words 'debit' and 'credit' in the definitions of 'mint' and 'burn' are intentionally used in the technical accounting sense of the term or not. The current wording implies that accounts are credit-normal (like a liability) and the total supply is debit-normal (like an asset). If that's the case, I think that that should be made explicit in the readme and the verbiage on

ds-token/README.md

Lines 18 to 24 in 13e0934

#### `mint`
credit tokens at an address whilst simultaniously increasing `totalSupply`
(requires auth)
#### `burn`
debit tokens at an address whilst simultaniously decreasing `totalSupply`
(requires auth)
should change to read more like

#### `mint`
increase (credit) tokens at an address whilst simultaneously increasing (debiting) `totalSupply`  
(requires auth) 

#### `burn` 
decrease (debit) tokens at an address whilst simultaneously decreasing (crediting) `totalSupply`  
(requires auth)
@rainbreak
Copy link
Member

rainbreak commented Mar 8, 2018

No, this is not intentional and there is no relation to the technical terms. We should probably change the wording to avoid confusion.

Perhaps drop the terms entirely:

#### `mint`
increase the `totalSupply` by increasing the balance of a specific address
(requires auth) 

#### `burn` 
decrease the `totalSupply` by decreasing the balance of a specific address
(requires auth)

@charles-cooper
Copy link
Author

Cool, thanks!

My own two cents is that using the double entry accounting terms can lend a lot of clarity since they have implications about money supply invariants - in this case totalSupply == sum(balances). The only question would be which accounts are debit/credit normal but I think making user balances credit normal would be most natural.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants