We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi,
The function DSToken.transferFrom emits an event Transfer, which is not documented in the README doc.
DSToken.transferFrom
Transfer
ds-token/src/token.sol
Line 80 in 16f187a
A potential fix could be adding "Emits a Transfer event" to the README doc.
Furthermore, function DSToken.transfer calls the function transferFrom. So it also emits the event Transfer.
DSToken.transfer
transferFrom
Line 63 in 16f187a
A potential fix could be also adding "Emits a Transfer event" to this function in the README doc.
Could you please check it?
Thanks.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hi,
The function
DSToken.transferFrom
emits an eventTransfer
, which is not documented in the README doc.ds-token/src/token.sol
Line 80 in 16f187a
A potential fix could be adding "Emits a
Transfer
event" to the README doc.Furthermore, function
DSToken.transfer
calls the functiontransferFrom
. So it also emits the eventTransfer
.ds-token/src/token.sol
Line 63 in 16f187a
A potential fix could be also adding "Emits a
Transfer
event" to this function in the README doc.Could you please check it?
Thanks.
The text was updated successfully, but these errors were encountered: