Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec.metadata.pemContents to MySQL/MariaDB Binding #4442

Open
edwardfward opened this issue Nov 30, 2024 · 0 comments · May be fixed by #4443
Open

Add spec.metadata.pemContents to MySQL/MariaDB Binding #4442

edwardfward opened this issue Nov 30, 2024 · 0 comments · May be fixed by #4443
Assignees
Labels
content/missing-information More information requested or needed waiting-on-code-pr The code PR needs to be merged before the docs are updated

Comments

@edwardfward
Copy link

What content needs to be created or modified?

MySQL & MariaDB binding

Add spec.metadata.pemContents to the component format as follows.

apiVersion: dapr.io/v1alpha1
kind: Component
metadata:
  name: <NAME>
spec:
  type: bindings.mysql
  version: v1
  metadata:
    - name: url # Required, define DB connection in DSN format
      value: "<CONNECTION_STRING>"
    - name: pemPath # Optional
      value: "<PEM PATH>"
    - name: pemContents # Optional
      value: "<PEM CONTENTS>"
    - name: maxIdleConns
      value: "<MAX_IDLE_CONNECTIONS>"
    - name: maxOpenConns
      value: "<MAX_OPEN_CONNECTIONS>"
    - name: connMaxLifetime
      value: "<CONNECTION_MAX_LIFE_TIME>"
    - name: connMaxIdleTime
      value: "<CONNECTION_MAX_IDLE_TIME>"

Add pemContents to spec metadata fields.

Field Required Binding support Details Example
pemContents N Output Contents of PEM file. Used with SSL connection. Supersedes pemPath "-----BEGIN CERTIFICATE-----
MIIFaDCCBFCgAwIBAgISESHkvZFwK9Qz0KsXD3x8p44aMA0GCSqGSIb3DQEBCwUA
...
bbml6YXRpb252YWxzaGEyZzIuY3JsMIGgBggrBgEFBQcBAQSBkzCBkDBNBggrBgEF
-----END CERTIFICATE-----"

Describe the solution you'd like

Adjust documentation to cover spec.metadata.pemContents

Where should the new material be placed?

MySQL & MariaDB binding in existing tables.

The associated pull request from dapr/dapr, dapr/components-contrib, or other Dapr code repos

Adding spec.metadata.pemContents to MySQL Binding #3620

Additional context

No additional context to provide.

@edwardfward edwardfward added the content/missing-information More information requested or needed label Nov 30, 2024
@hhunter-ms hhunter-ms added the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content/missing-information More information requested or needed waiting-on-code-pr The code PR needs to be merged before the docs are updated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants