Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring middleware in the component #3937

Open
wants to merge 16 commits into
base: v1.13
Choose a base branch
from

Conversation

hhunter-ms
Copy link
Collaborator

Description

New doc for configuring middleware
Add new middleware node under 'Developing Applications/Components"

Issue reference

PR will close: #3917

@hhunter-ms hhunter-ms added this to the 1.13 milestone Jan 4, 2024
@hhunter-ms hhunter-ms self-assigned this Jan 4, 2024
Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms hhunter-ms requested a review from sadath-12 January 5, 2024 14:47
@hhunter-ms hhunter-ms marked this pull request as ready for review January 9, 2024 17:25
@hhunter-ms hhunter-ms requested review from a team as code owners January 9, 2024 17:25
@sadath-12
Copy link

sadath-12 commented Jan 9, 2024

Thanks for the pr @hhunter-ms . left some comments

@sadath-12
Copy link

sadath-12 commented Jan 9, 2024

consider also adding these points --


We are adding 2 new metadata options (all keys and values are handled as case-insensitive):
pipeline can be set to httpPipeline or appHttpPipeline (we'll have aliases including http-pipeline and http for the first; app-http-pipeline and app for the second)
priority is an integer from -MaxInt32 to +MaxInt32
Both metadata options are required for the component to be enabled in a pipeline. For backwards-compatibility, there's no default priority.

Components with lower priorities are executed first
Priorities don't necessarily need to be sequential. In the docs, we will document as best practice the use of values like "100", "200", "300", etc - so changing the order is less complex


just pasting it from the design issue. you can re-fashion it

Signed-off-by: Hannah Hunter <[email protected]>
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make sure you read the proposal conclusion for this feature here dapr/dapr#6660 (comment) for each of my comments

Signed-off-by: Hannah Hunter <[email protected]>
@hhunter-ms hhunter-ms added the waiting-on-code-pr The code PR needs to be merged before the docs are updated label Jan 25, 2024
@hhunter-ms hhunter-ms modified the milestones: 1.13, 1.14 Jan 25, 2024
@msfussell msfussell modified the milestones: 1.14, 1.15 Jun 19, 2024
@hhunter-ms hhunter-ms modified the milestones: 1.15, 1.16 Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge waiting-on-code-pr The code PR needs to be merged before the docs are updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure middleware within the component
3 participants