Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates documentation for circuit breaker with possible values and adds examples #4413

Draft
wants to merge 4 commits into
base: v1.15
Choose a base branch
from
Draft

Updates documentation for circuit breaker with possible values and adds examples #4413

wants to merge 4 commits into from
+1 −1

Conversation

elena-kolevska
Copy link
Contributor

No description provided.

@elena-kolevska
Updates docs for circuit breaker
9069159 
Signed-off-by: Elena Kolevska <[email protected]>
@elena-kolevska elena-kolevska requested review from a team as code owners October 31, 2024 17:48
@elena-kolevska elena-kolevska mentioned this pull request Oct 31, 2024
Merged
7 tasks
@hhunter-ms
Copy link
Collaborator

@elena-kolevska under trip, can you have more than one value? ie: totalFailures and requests? If so, can you add to the code example below the table to show the syntax for having two values? would it look something like this: request > 5 && totalFailures > 3

@elena-kolevska
Copy link
Contributor Author

Great question. I did some tests and totalFailures > 2 || requests > 5 for example is accepted, but the behaviour is not as you'd expect. I'll move this to draft and look some more into it.

@elena-kolevska elena-kolevska marked this pull request as draft October 31, 2024 19:18
@hhunter-ms hhunter-ms added this to the 1.15 milestone Nov 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Nov 7, 2024
@github-actions github-actions bot closed this Nov 14, 2024
@hhunter-ms hhunter-ms reopened this Nov 19, 2024
@hhunter-ms hhunter-ms removed the stale label Nov 19, 2024
@github-actions GitHub Actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Nov 25, 2024
@hhunter-ms hhunter-ms removed the stale label Nov 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2024

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Dec 1, 2024
@hhunter-ms hhunter-ms removed the stale label Dec 2, 2024
@msfussell
Copy link
Member

@elena-kolevska - Any update here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@elena-kolevska elena-kolevska

Labels
None yet
Projects
None yet
Milestone
1.15
Development

Successfully merging this pull request may close these issues.
3 participants
@elena-kolevska @hhunter-ms @msfussell