Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Secrets manager to beta #4421

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

elena-kolevska
Copy link
Contributor

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Issue reference

@elena-kolevska
Copy link
Contributor Author

@hhunter-ms is there anything else needed for making a component Beta in the docs?
The work on the code side has been done here: dapr/components-contrib#3588

@elena-kolevska elena-kolevska marked this pull request as ready for review November 11, 2024 17:52
@elena-kolevska elena-kolevska requested review from a team as code owners November 11, 2024 17:52
@hhunter-ms
Copy link
Collaborator

hhunter-ms commented Nov 14, 2024

@elena-kolevska sorry for the delay - the only other update I can think of is here in the component example: https://docs.dapr.io/reference/components-reference/supported-secret-stores/aws-secret-manager/

changing

apiVersion: dapr.io/v1alpha1

to

apiVersion: dapr.io/v1beta1

@msfussell can you think of anything else?

@hhunter-ms
Copy link
Collaborator

@elena-kolevska sorry for the delay - the only other update I can think of is here in the component example: https://docs.dapr.io/reference/components-reference/supported-secret-stores/aws-secret-manager/

changing

apiVersion: dapr.io/v1alpha1

to

apiVersion: dapr.io/v1beta1

lol I'm thinking of APIs - we don't do this with components. Sorry about that. Approving now!

@hhunter-ms hhunter-ms merged commit e43df4f into dapr:v1.15 Nov 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants