Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade go version from 1.19 to 1.20 #407

Closed
hunter007 opened this issue May 21, 2023 · 4 comments
Closed

Upgrade go version from 1.19 to 1.20 #407

hunter007 opened this issue May 21, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@hunter007
Copy link
Contributor

Describe the solution you'd like
According the release notes of go1.20, no change for codes.

https://tip.golang.org/doc/go1.20
@hunter007 hunter007 added the enhancement New feature or request label May 21, 2023
@ItalyPaleAle
Copy link
Contributor

I think we should wait, because this makes it so all consumers of the SDK will need to use 1.20.

We should update the Go version in go.mod only when we need to depend on some new features IMHO. And try to support at least N-1.

@hunter007
Copy link
Contributor Author

Agree with you.

@mikeee
Copy link
Member

mikeee commented Aug 17, 2023

Should the validate-examples github workflow go-version be bumped down to 1.19 in this case if we're still using 1.19?

@mikeee
Copy link
Member

mikeee commented Feb 25, 2024

Addressed by #480

@mikeee mikeee closed this as completed Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ItalyPaleAle @hunter007 @mikeee