Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update python workflow example with daprWorkflowClient #1101

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

Eileen-Yu
Copy link
Contributor

@Eileen-Yu Eileen-Yu commented Nov 25, 2024

Description

Notice the python quickstart example is outdated, so update it to use DaprWorkflowClient instead of DaprClient, same as here in python-sdk repo https://github.com/dapr/python-sdk/blob/main/examples/workflow/child_workflow.py

Checked mm.py and verify it works

Issue reference

#1119

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@Eileen-Yu Eileen-Yu requested review from a team as code owners November 25, 2024 23:56
@elena-kolevska
Copy link

Great work @Eileen-Yu , thanks!

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit c32f421 into dapr:master Nov 29, 2024
7 checks passed
@msfussell
Copy link
Member

Yes. This is excellent @Eileen-Yu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants