Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panasonic DMC-FX150 support #705

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Apr 2, 2024

Resolves darktable-org/darktable#16554

Missing the full set of aspect ratios though. @abpolly

@LebedevRI
Copy link
Member

@kmilos please change your commit message template :)
It's quite unfortunate (read: wrong) that merging change here closes the issue in darktable repo.

@kmilos
Copy link
Collaborator Author

kmilos commented Apr 3, 2024

OK, I'll go back to "addresses" then...

@LebedevRI
Copy link
Member

OK, I'll go back to "addresses" then...

Refs. <link> is best. It still causes github to cross-reference, but does not auto-close them.
Addresses might or might not auto-close, i don't know.

@kmilos
Copy link
Collaborator Author

kmilos commented Apr 3, 2024

Addresses might or might not auto-close, i don't know.

It doesn't, and is what I used for a while... But then at some point I thought you asked me to do auto-closing, but I must have misunderstood...

@LebedevRI
Copy link
Member

Addresses might or might not auto-close, i don't know.

It doesn't, and is what I used for a while...

But then at some point I thought you asked me to do auto-closing, but I must have misunderstood...

Hm, if i did, i was talking about auto-closing issues in this repo, not in darktable one.
Anyways, there's no problem, just a bit unfortunate. Thank you!

@kmilos
Copy link
Collaborator Author

kmilos commented Apr 3, 2024

Hm, if i did, i was talking about auto-closing issues in this repo, not in darktable one.

Got it, thanks.

@kmilos kmilos force-pushed the kmilos/panny_fx150 branch from 238d038 to 6b17d65 Compare April 7, 2024 09:02
@kmilos kmilos removed the incomplete label Apr 7, 2024
@LebedevRI
Copy link
Member

Looks good, but we really need @abpolly to contribute the samples...

@abpolly
Copy link

abpolly commented Apr 8, 2024 via email

@LebedevRI LebedevRI merged commit 57f9405 into darktable-org:develop Apr 8, 2024
56 of 57 checks passed
@LebedevRI
Copy link
Member

@kmilos thank you!

@kmilos kmilos deleted the kmilos/panny_fx150 branch April 8, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Resolved
Development

Successfully merging this pull request may close these issues.

Panasonic DMC-FX150
3 participants